On 11/16/26 1:55 PM, Lucas Vargas Dias via dev wrote:
> The ECMP group id and the member ids are written into the
> lr_in_ip_routing and lr_in_ip_routing_ecmp logical flows, but they
> were assigned from the order in which routes reached
> en_group_ecmp_route: the group id was hmap_count() at creation time
> and the member id was the insertion position. On a full recompute
> the routes are walked in hmap order, while incremental processing
> appends them in event order, so the same set of routes could get a
> different numbering. Every forced or fallback recompute could then
> delete and re-insert Logical_Flow rows in the Southbound DB even
> though nothing had changed.
>
> Derive the ids from hashes instead. The group id comes from the
> group key, i.e. prefix, prefix length, route table, source or
> destination route and source class, which does not change as members
> are added or removed. The member id comes from the UUID of the
> route's source row, its nexthop and its output port: a NAT or LB row
> produces one route per path to the peer router, so the UUID alone is
> not unique within a group.
>
> When two elements derive the same id, all of them retry in the next
> round with an id derived from their hash and the round number, so
> that the ids only depend on the set of routes and not on the order
> in which they were processed. Elements with equal hashes can't be
> told apart, so they skip the retries and take the next free id. The
> members are listed in the select() action in id order for the same
> reason.
>
> Besides making a recompute produce the same flows as incremental
> processing, adding or removing a route no longer changes the ids,
> and so the flows, of unrelated groups or members.
>
> Fixes: 6979a96138a2 ("northd: Support I+P for group_ecmp_route engine.")
> Fixes: 5395e12f247c ("northd: Drop traffic for ECMP group with "discard"
> route.")
> Suggested-by: Rosemarie O'Riorden <[email protected]>
> Assisted-by: Claude Opus 5.5, Claude Code
> Acked-by: Rosemarie O'Riorden <[email protected]>
> Signed-off-by: Lucas Vargas Dias <[email protected]>
> ---
Hi Lucas,
Thanks for the backport patch, applied to 26.03!
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev