Eric Dumazet <[email protected]> writes: > Hyunwoo Kim reported that a long chain of IPv6 extension headers > can push the transport header offset of a GRO packet beyond what > the 16-bit skb->transport_header can store. The truncated offset > is later used by gro_receive_network_flush() to locate the network > header of a packet held in the GRO list, leading to an out-of-bounds > read. > > Since commit 3744b0964d52 ("ipv6: Implement limits on extension header > parsing"), ip6_protocol_deliver_rcu() drops packets carrying more than > IP6_MAX_EXT_HDRS_CNT extension headers, but ipv6_gro_pull_exthdrs() > was left unbounded. > > There is no point trying to aggregate packets that the stack is going > to drop anyway if they are locally delivered. Apply the same limit in > ipv6_gro_pull_exthdrs(). > > When the limit is hit, @proto still designates an extension header. > Extension header offloads have no gro_receive() callback, so > ipv6_gro_receive() takes its existing "goto out" path with flush set, > and the packet is given to the normal receive path. Local delivery > drops it with SKB_DROP_REASON_IPV6_TOO_MANY_EXTHDRS, while forwarded > packets are simply not aggregated. > > An extension header being at most 2048 bytes, this bounds a chain > to 24576 bytes. > > Note that offsets can still accumulate over nested encapsulations, > so the places storing them should be hardened separately. > > Fixes: 4b0ebbca3e16 ("net: gro: move L3 flush checks to tcp_gro_receive and > udp_gro_receive_segment") > Cc: [email protected] > Reported-by: Hyunwoo Kim <[email protected]> > Link: https://lore.kernel.org/netdev/avTTQNyvwPP6LtGx@v4bel/ > Signed-off-by: Eric Dumazet <[email protected]> > Cc: Daniel Borkmann <[email protected]> > Cc: David Ahern <[email protected]> > Cc: Ido Schimmel <[email protected]> > ---
Reviewed-by: Aaron Conole <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
