On 18 July 2017 at 13:41, Greg Rose <[email protected]> wrote: > On 07/18/2017 01:23 PM, Joe Stringer wrote: >> >> On 18 July 2017 at 13:08, Greg Rose <[email protected]> wrote: >> > On 07/18/2017 10:16 AM, Darrell Ball wrote: >> >> >> >> >> >> >> >> On 7/18/17, 8:42 AM, "[email protected] on behalf of Greg >> >> Rose" <[email protected] on behalf of >> >> [email protected]> >> >> wrote: >> >> >> >> From: Joe Stringer <[email protected]> >> >> Add a new test check if the conntrack force direction change >> >> and >> >> commit is working correctly. >> >> >> >> You are adding a new check to an existing test (‘force commit’). >> >> The existing test already checked for conntrack force direction change. >> > >> > >> > Oh. OK, I just went from this change: >> > >> > +priority=100,in_port=1,udp,action=ct(force,commit),controller >> > >> > And that looks like a new test for force and commit to me but >> > obviously I don't know the entire context. >> > >> > Joe originated this patch and asked me to send it along with my >> > other bug fix commit. Clearly I need some help on what this >> > patch is actually doing. Let me see what he thinks. >> >> In autotest parlance, the part between AT_SETUP and AT_CLEANUP is a >> test, so you updated the test (which, yes, tests something slightly >> more). >> >> Don't worry about re-sending though, I can fix this up when I apply this. >> > Thank you!
Thanks, I applied this patch to master. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
