On 28 July 2017 at 10:05, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Jul 27, 2017 at 05:59:54PM -0700, Justin Pettit wrote: > > > > > On Jul 27, 2017, at 4:03 PM, Han Zhou <zhou...@gmail.com> wrote: > > > > > > > > > > > > On Wed, Jul 26, 2017 at 1:55 PM, Justin Pettit <jpet...@ovn.org> > wrote: > > > > @@ -332,7 +333,7 @@ Logical switch commands:\n\ > > > > ls-list print the names of all logical > switches\n\ > > > > \n\ > > > > ACL commands:\n\ > > > > - acl-add SWITCH DIRECTION PRIORITY MATCH ACTION [log]\n\ > > > > + acl-add [--log] SWITCH DIRECTION PRIORITY MATCH ACTION\n\ > > > > > > The optional "name" and "severity" are missing in the help message. > > > > Yes, I was running out of space on an 80-column terminal. I think we > > have other examples of dropping non-essential parameters. I'll poke > > around to see what other project do. > > Perhaps abbreviations: > acl-add [--log] LS DIR PRI MATCH ACTION NAME SEVERITY > or similar. > > (However, this is getting more and more awful and maybe we should > support a key=value format.) >
A little unrelated, but it would have beeen nice if acl-add returns a uuid. Now, after a acl-add we need to be smart trying to figure out the UUID and add any external-ids to it. > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
