> On Jul 28, 2017, at 4:57 PM, Ben Pfaff <[email protected]> wrote: > > On Fri, Jul 28, 2017 at 03:48:38PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <[email protected]> >> Acked-by: Han Zhou <[email protected]> >> --- >> v1->v2: Incorporate Ben and Han's feedback. >> Improve output of "ovn-nbctl acl-list". > > Thank you! > > I'm appending a few final suggestions. The only important one is the > one that moves the free() call, which I believe fixes a double-free on > the error path: the old name is freed but not set to NULL, which means > that ovnact_log_free() eventually frees it again.
Good catches. I added your changes and pushed to master. Thanks! --Justin _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
