-----Original Message-----
From: Aaron Conole <[email protected]>
Date: Sunday, July 30, 2017 at 8:22 AM
To: Darrell Ball <[email protected]>
Cc: Michal Weglicki <[email protected]>, "[email protected]"
<[email protected]>
Subject: Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for
DPDK 17.05.1.
Darrell Ball <[email protected]> writes:
> -----Original Message-----
> From: <[email protected]> on behalf of Michal Weglicki
<[email protected]>
> Date: Tuesday, July 25, 2017 at 5:34 AM
> To: "[email protected]" <[email protected]>
> Subject: [ovs-dev] [PATCH v4] Update relevant artifacts to add support
for DPDK 17.05.1.
>
> Upgrading to DPDK 17.05.1 stable release adds new
> significant features relevant to OVS, including,
> but not limited to:
> - tun/tap PMD,
> - VFIO hotplug support,
> - Generic flow API.
>
> Following changes are applied:
> - netdev-dpdk: Changes required by DPDK API modifications.
> - doc: Because of DPDK API changes, backward compatibility
> with previous DPDK releases will be broken, thus all
> relevant documentation entries are updated.
> - .travis: DPDK version change from 16.11.1 to 17.05.1.
> - rhel/openvswitch-fedora.spec.in: DPDK version change
> from 16.11 to 17.05.1
>
> v1->v2: Patch rebase.
> v2->v3: Fixed wrong formating after v2 patch rebase.
> v3->v4: Minor documentation changes.
>
> Signed-off-by: Michal Weglicki <[email protected]>
> Reviewed-by: Aaron Conole <[email protected]>
> ---
> .travis/linux-build.sh | 2 +-
> Documentation/faq/releases.rst | 1 +
> Documentation/howto/dpdk.rst | 6 +-
> Documentation/intro/install/dpdk.rst | 14 +--
> Documentation/topics/dpdk/vhost-user.rst | 12 +--
> NEWS | 1 +
> lib/netdev-dpdk.c | 144
+++++++++++++++++++------------
> rhel/openvswitch-fedora.spec.in | 2 +-
> tests/dpdk/ring_client.c | 6 +-
> 9 files changed, 114 insertions(+), 74 deletions(-)
>
> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
> index f66b534..efccdf1 100755
> --- a/.travis/linux-build.sh
> +++ b/.travis/linux-build.sh
> @@ -80,7 +80,7 @@ fi
>
> if [ "$DPDK" ]; then
> if [ -z "$DPDK_VER" ]; then
> - DPDK_VER="16.11.2"
> + DPDK_VER="17.05.1"
> fi
> install_dpdk $DPDK_VER
> if [ "$CC" = "clang" ]; then
> diff --git a/Documentation/faq/releases.rst
b/Documentation/faq/releases.rst
> index 707834b..2ecc24c 100644
> --- a/Documentation/faq/releases.rst
> +++ b/Documentation/faq/releases.rst
> @@ -161,6 +161,7 @@ Q: What DPDK version does each Open vSwitch
release work with?
> 2.5.x 2.2
> 2.6.x 16.07.2
> 2.7.x 16.11.2
> + 2.8.x 17.05.1
> ============ =======
>
> Q: I get an error like this when I configure Open vSwitch:
> diff --git a/Documentation/howto/dpdk.rst
b/Documentation/howto/dpdk.rst
> index af01d3e..1756c8c 100644
> --- a/Documentation/howto/dpdk.rst
> +++ b/Documentation/howto/dpdk.rst
> @@ -528,15 +528,15 @@ described in :ref:`dpdk-testpmd`. Once
compiled, run the application::
>
> When you finish testing, bind the vNICs back to kernel::
>
> - $ $DPDK_DIR/tools/dpdk-devbind.py --bind=virtio-pci 0000:00:03.0
> - $ $DPDK_DIR/tools/dpdk-devbind.py --bind=virtio-pci 0000:00:04.0
> + $ $DPDK_DIR/usertools/dpdk-devbind.py --bind=virtio-pci
0000:00:03.0
> + $ $DPDK_DIR/usertools/dpdk-devbind.py --bind=virtio-pci
0000:00:04.0
>
> .. note::
>
> Valid PCI IDs must be passed in above example. The PCI IDs can be
retrieved
> like so::
>
> - $ $DPDK_DIR/tools/dpdk-devbind.py --status
> + $ $DPDK_DIR/usertools/dpdk-devbind.py --status
>
> More information on the dpdkvhostuser ports can be found in
> :doc:`/topics/dpdk/vhost-user`.
>
> [Darrell]
> While dealing with something else, I noticed that this file has an
outdated reference,
> as of OVS 2.8/DPDK 17.05.1, to VFIO not supporting hotplug. Specifically,
the text
>
> “This feature is not supported with VFIO” under “Port Hotplug”
>
> It will be removed unless someone objects.
>
> //////////////////
That makes sense.
OTOH, how is it going to work as far as applying / pulling / etc. goes?
I know that the DPDK related work is planning on going with a
pull-request model. Does that mean this patch is applied to your branch
and you will submit a pull request with it at some point?
[Darrell]
Right.
How about
work that builds on this patch? As an example,
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_pipermail_ovs-2Ddev_2017-2DJuly_335250.html&d=DwIFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=FSHC_5hvqniBmseIL_5bT8jWrzB0GdkTg4pt_u9a5MY&s=ovw7pxgYKy81nrb2hiiBmebXdzFPy3OzgptTCBKUtlI&e=
I'd like to submit my latest work for this series, but not sure where or
how.
[Darrell]
I have followed your series; since it is related to packaging and infra, it is
outside the scope of dpdk core changes.
Your series should go thru. the usual path.
The code for this patch (i.e. Update relevant artifacts to add support for DPDK
17.05.1.) has converged (tested by several people)
and is not changing, so your series can simply say it is based on this patch.
We have identified patches in the past as depending on
another patch, which is not yet applied. In this case, it is more simple, since
the code for this patch
(i.e. Update relevant artifacts to add support for DPDK 17.05.1.) will not
change. If there is anything going forward, it will be a
separate bug fix.
-Aaron
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
