This patch series is used to fix generating packet conntrack metadata from odp key. The existing optimization logic in odp_key_to_dp_packet() may lead to missing the conntrack fields if all the wanted fields are generated. This bug is not obvious in the master branch because the ovs kernel module serializes OVS_KEY_ATTR_ETHERTYPE and OVS_KEY_ATTR_ETHERNET in the latest stage, therefore, odp_key_to_dp_pakcet() will loop through all the attributes. However, it may cause problems in other earlier branches, which leads to some conntrack related issues.
First two patches is used for backporting. The third one removes the optimization logic. Some refactoring is done in the fourth patch. Yi-Hung Wei (4): odp-util: Fix generating various ct fields in odp_key_to_dp_packet() odp-util: Fix generating ct_orig_tuple in odp_key_to_dp_packet() odp-util: Remove unnecessary optimization in odp_key_to_dp_packet() odp-util: Refactor odp_key_to_dp_pakcet() lib/odp-util.c | 41 +++++++++++++++++------------------------ 1 file changed, 17 insertions(+), 24 deletions(-) -- 2.7.4 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
