This inner 'xcfg' shadowed the outer one and could have read a different value if 'xcfgp' was changing, so this is possibly a bug fix.
Found by -Wshadow=local in GCC 7. Signed-off-by: Ben Pfaff <[email protected]> --- ofproto/ofproto-dpif-xlate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index c1037936723c..b2698b93b674 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -6568,7 +6568,6 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) /* Set the bridge for post-recirculation processing if needed. */ if (!uuid_equals(&ctx.xbridge->ofproto->uuid, &state->ofproto_uuid)) { - struct xlate_cfg *xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); const struct xbridge *new_bridge = xbridge_lookup_by_uuid(xcfg, &state->ofproto_uuid); -- 2.10.2 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
