On Tue, Aug 08, 2017 at 02:30:28PM -0700, Joe Stringer wrote:
> If a libopenvswitch user includes ofp-print.h before ofp-util.h (which
> is standard alphabetical order), and turns on -Werror, then they would
> hit this compilation error in the include:
>
> error: 'struct ofputil_port_map' declared inside parameter list will not
> be visible outside of this definition or declaration [-Werror]
> void ofp_print(FILE *, const void *, size_t *, const struct ofputil_port_map
> *,
>
> Fixes: 50f96b10e1c8 ("Support accepting and displaying port names in OVS
> tools.")
> Signed-off-by: Joe Stringer <[email protected]>
Our usual practice of having a .c file #include its own .h first should
defend against this, but I see that it wasn't followed here. I'll send
a followup patch.
Acked-by: Ben Pfaff <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
