Previously, netdev_ports_insert() would allocate and insert an
ifindex->odp_port mapping, but netdev_ports_remove() would never remove
the mapping or free the mapping structure. This patch fixes these up.
Fixes: 32b77c316d9982("dpif: Save added ports in a port map.")
Reported-by: Andy Zhou <[email protected]>
Signed-off-by: Joe Stringer <[email protected]>
---
v3: First post.
---
lib/netdev.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/lib/netdev.c b/lib/netdev.c
index 7e9896b82928..a8f5348264c8 100644
--- a/lib/netdev.c
+++ b/lib/netdev.c
@@ -2266,9 +2266,20 @@ netdev_ports_remove(odp_port_t port_no, const struct
dpif_class *dpif_class)
data = netdev_ports_lookup(port_no, dpif_class);
if (data) {
+ int ifindex = netdev_get_ifindex(data->netdev);
+ struct ifindex_to_port_data *ifidx;
+
+ HMAP_FOR_EACH_WITH_HASH (ifidx, node, ifindex, &ifindex_to_port) {
+ if (ifidx->port == port_no) {
+ break;
+ }
+ }
+
dpif_port_destroy(&data->dpif_port);
netdev_close(data->netdev); /* unref and possibly close */
+ hmap_remove(&ifindex_to_port, &ifidx->node);
hmap_remove(&port_to_netdev, &data->node);
+ free(ifidx);
free(data);
ret = 0;
}
--
2.13.3
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
