On Fri, Aug 04, 2017 at 09:54:26AM -0400, Lance Richardson wrote: > > From: "Ben Pfaff" <[email protected]> > > To: [email protected] > > Cc: "Ben Pfaff" <[email protected]>, "Stuart Cardall" > > <[email protected]> > > Sent: Friday, 14 July, 2017 12:42:54 AM > > Subject: [ovs-dev] [PATCH] ovs-vsctl-bashcomp: Make compatible with busybox > > "awk". > > > > It seems that awk in busybox doesn't think that an empty string is part of > > a larger string, but that GNU awk does. This commit adds an extra test to > > make _ovs_vsctl_check_startswith_string work either way. > > > > This allows the following tests to pass with busybox awk: > > > > vsctl bashcomp unit tests > > > > 7: vsctl-bashcomp - basic verification ok > > 8: vsctl-bashcomp - argument completion ok > > > > Reported-by: Stuart Cardall <[email protected]> > > Signed-off-by: Ben Pfaff <[email protected]> > > --- > > Makes sense, verified that these test cases now pass in the Alpine > environment with busybox awk. > > Acked-by: Lance Richardson <[email protected]>
Thanks for the review. I applied this to master and branch-2.8. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
