On Fri, Aug 04, 2017 at 09:54:26AM -0400, Lance Richardson wrote:
> > From: "Ben Pfaff" <b...@ovn.org>
> > To: d...@openvswitch.org
> > Cc: "Ben Pfaff" <b...@ovn.org>, "Stuart Cardall" 
> > <develo...@it-offshore.co.uk>
> > Sent: Friday, 14 July, 2017 12:42:54 AM
> > Subject: [ovs-dev] [PATCH] ovs-vsctl-bashcomp: Make compatible with busybox 
> > "awk".
> > 
> > It seems that awk in busybox doesn't think that an empty string is part of
> > a larger string, but that GNU awk does.  This commit adds an extra test to
> > make _ovs_vsctl_check_startswith_string work either way.
> > 
> > This allows the following tests to pass with busybox awk:
> > 
> > vsctl bashcomp unit tests
> > 
> >   7: vsctl-bashcomp - basic verification             ok
> >   8: vsctl-bashcomp - argument completion            ok
> > 
> > Reported-by: Stuart Cardall <develo...@it-offshore.co.uk>
> > Signed-off-by: Ben Pfaff <b...@ovn.org>
> > ---
> 
> Makes sense, verified that these test cases now pass in the Alpine
> environment with busybox awk.
> 
> Acked-by: Lance Richardson <lrich...@redhat.com>

Thanks for the review.  I applied this to master and branch-2.8.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to