On Wed, Aug 09, 2017 at 03:27:32PM -0400, Russell Bryant wrote:
> On Tue, Aug 8, 2017 at 2:44 PM, Lance Richardson <lrich...@redhat.com> wrote:
> > Ensure that JSON is utf-8 encoded and that bytes sent/received on
> > the stream sockets are in utf-8 form. Add a test case to verify
> > that unicode column data can be sent/received successfully using
> > Python module.
> > JSON encoder magic to ensure utf-8 encoding suggested by Terry
> > Wilson.
> > Suggested-by: Terry Wilson <twil...@redhat.com>
> > Signed-off-by: Lance Richardson <lrich...@redhat.com>
> > ---
> > python/ovs/json.py | 9 +++++++--
> > python/ovs/jsonrpc.py | 3 +--
> > python/ovs/stream.py | 6 ++++--
> > tests/ovsdb-idl.at | 13 +++++++++++++
> > tests/test-ovsdb.py | 5 ++++-
> > 5 files changed, 29 insertions(+), 7 deletions(-)
> We discussed this patch on IRC, but for the record:
> There's a line in test-ovsdb.py that's too long. flake8 complained
> about it for me.
> The changes to ovsdb-idl.at contain some unicode that my terminal
> chokes on. After spending far too much time trying to figure out why,
> I was able to work around it by changing the crazy face to an
> appropriate alternative which seems to work OK: (╯°□°）╯︵ ┻━┻
Russell, do you want to handle the review for this? It looks OK to me
but it sounds like you have some specific changes to make, so I think
you should go for it.
dev mailing list