On 17/08/2017 01:17, Joe Stringer wrote:
On 16 August 2017 at 05:14, Roi Dayan <[email protected]> wrote:
Doing dump-flows also altering the netdev ports list.
So doing it pre the actual test is adding a check to
make sure we don't break the that list.
Signed-off-by: Roi Dayan <[email protected]>
Reviewed-by: Paul Blakey <[email protected]>
I'm actually not sure what the requirements are to run these offload
tests. I tried running them on a 4.4 kernel, and the first test passed
while the second failed; I assume that this is because 4.4's TC flower
support is not new enough.
Then I tried with a 4.12 kernel and neither test passed, and I have
extra flows being reported in the dump-flows output.
I believe that I understand what this patch is trying to achieve, but
I don't know how I'm supposed to validate it.
strange. there are no special requirements and this test should work
with kernel 4.10 and up I think.
Without the fix the first pass and the second fails.
With the fix the first and second pass.
I currently I test using kernel 4.13-rc2 and this is my output:
before the fix:
# make check-offloads
..
datapath offloads
1: offloads - ping between two ports - offloads disabled ok
2: offloads - ping between two ports - offloads enabled FAILED
(system-offloads-traffic.at:55)
after the fix:
# make check-offloads
..
datapath offloads
1: offloads - ping between two ports - offloads disabled ok
2: offloads - ping between two ports - offloads enabled ok
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
