I applied this on master and branch-2.8 Thanks, Alin.
> -----Original Message----- > From: [email protected] [mailto:ovs-dev- > [email protected]] On Behalf Of Alin Serdean > Sent: Thursday, August 17, 2017 10:47 PM > To: Anand Kumar <[email protected]>; [email protected] > Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Do not modify port > field for ICMP during SNAT/DNAT > > Thanks a lot for the patch and changes! > > Acked-by: Alin Gabriel Serdean <[email protected]> > > > -----Original Message----- > > From: [email protected] [mailto:ovs-dev- > > [email protected]] On Behalf Of Anand Kumar > > Sent: Wednesday, August 16, 2017 1:29 AM > > To: [email protected] > > Subject: [ovs-dev] [PATCH v2] datapath-windows: Do not modify port > > field for ICMP during SNAT/DNAT > > > > During SNAT/DNAT, we should not be updating the port field of > > ct_endpoint struct, as ICMP packets do not have port information. > > Since port and icmp_id are overlapped in ct_endpoint struct, icmp_id gets > changed. > > As a result, NAT look up fails to find a matching entry. > > > > This patch addresses this issue by not modifying icmp_id field during > > SNAT/DNAT only for ICMP traffic > > > > The current NAT module doesn't take the ICMP type/code into account > > during the lookups. Fix this to make it similar with the other > > conntrack module. > > > > Signed-off-by: Anand Kumar <[email protected]> > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
