On Tue, Aug 15, 2017 at 9:15 AM, Aaron Conole <[email protected]> wrote:
> Hi Mark,
>
> Mark Michelson <[email protected]> writes:
>
>> Earlier today on IRC I brought up an error I had while attempting to use
>> pwclient to get a patch from patchwork. Here [1] is the pastebin I linked
>> to. At the time, I thought it was due to HTTP chunked encoding being used
>> and the xmlrpclib or HTTP client library not handling that properly.
>>
>> I debugged the problem further and I now have figured out that the problem
>> has to do with a form feed character being present in the patch. The
>> Patchwork server places the patch text inside an XML 1.0 document; however,
>> form-feeds are illegal in XML 1.0 [2]. This makes the use of form feeds and
>> the use of pwclient incompatible.
>>
>> Aaron Conole pointed out that once Patchwork 2.0 is available, the git-pw
>> command will render pwclient obsolete. I checked, and git-pw will use
>> Patchwork 2.0's REST API (which is JSON-based) instead of XMLRPC, so this
>> is indeed only a temporary problem.
>>
>> In the meantime, is there some other command line tool OVS devs use instead
>> of pwclient for getting patches?
>
> I use curl. I guess pwclient could probably be patched to fix this
> issue. However, I think the xmlrpc interface isn't as nice as the
> RESTful api being implemented by patchwork 2.0.
I've never actually used pwclient. I use curl for applying patches
and the web interface otherwise. Specifically:
$ curl ${PATCHWORK_MBOX_LINK} | git am -3
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
