On 08/23/2017 04:21 PM, Joe Stringer wrote:
On 23 August 2017 at 11:21, Greg Rose <[email protected]> wrote:
> Upstream commit:
> commit 880388aa3c07fdea4f9b85e35641753017b1852f
> Author: David S. Miller <[email protected]>
> Date: Mon Jul 3 07:29:12 2017 -0700
>
> net: Remove all references to SKB_GSO_UDP.
>
> Such packets are no longer possible.
>
> Signed-off-by: David S. Miller <[email protected]>
>
> Apply openvswitch section of this upstream patch.
>
> Signed-off-by: Greg Rose <[email protected]>
> ---
I think that the background context of this patch is that there are no
SKB_GSO_UDP frames in the latest upstream versions of the kernel.
However, in the OVS datapath we will be running against earlier
kernels that still have these flags. If we think that this could
impact forwarding (and we care about such configurations on older
kernels) then we might have to consider #ifdefing these pieces.
Otherwise this seems OK.
Ah, right. The patches all passed a travis build for the various kernels but
that doesn't necessarily mean it
all works right. I'll add the appropriate acinclude check and #ifdef and then
send a V2.
Thanks for the review!
- Greg
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev