On Thu, Aug 24, 2017 at 11:15:35PM +0000, Shashank Ram wrote: > > > ________________________________________ > From: [email protected] <[email protected]> on > behalf of Ben Pfaff <[email protected]> > Sent: Wednesday, August 2, 2017 11:35 AM > To: Alin Serdean > Cc: [email protected] > Subject: Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings. > > On Fri, Jul 14, 2017 at 04:40:51AM +0000, Alin Serdean wrote: > > The following patches are fixes found with the WDK 8.1 and 10 > > static code analysis. > > I applied most of this series to master. The patches that I didn't > apply are the ones where Shashank had some requests. (Alin, you should > be able to find the remaining patches by simply rebasing the series > against current master--the patches that were applied will disappear on > rebase.) > > Thank you very much! > _______________________________________________ > > Hi Ben, all the 40 patches in this series have been applied to > master. Some of the patches have issues such as memory leaks as I > pointed out in my review. Were these applied by mistake?
If that's what happened, then yes it was a mistake. But I don't think it's true. I applied the following 33 commits on August 2, omitting the other 7: 1e30f5fa96d8 datapath-windows: Fix shared variables which use Interlocked functions 17cf43bce5b3 datapath-windows: Add annotation for OvsIpFragmentEntryCleaner 553966a7942c datapath-windows: Add annotation for OvsCtRelatedEntryCleaner 7ce89fa2d4a6 datapath-windows: Treat TCP_HDR_LEN static analysis warnings 3630a2f32122 datapath-windows: Check return status when using APIs 1c5875f7d9d7 datapath-windows: fix excessive stack usage in iphelper f0aeea81bd27 datapath-windows: Add dummy parameter for NotifyRouteChange2 20804d501994 datapath-windows: Suppress warning in jhash 445995a8e270 datapath-windows: Fix possible NULL deference in OvsFullCopyNBL 0d4374aa82de datapath-windows: Add assert in OvsPartialCopyNBL b27b4e5f05a6 datapath-windows: Use annotations instead for macros c5a12e53f86f datapath-windows: Fix misspelling in comment. f0187396b0a7 datapath-windows: Add annotations for OvsAcquirePidHashLock cfc854f0bad5 datapath-windows: Add annotations for OvsReleasePidHashLock 7dcfa473bfb6 datapath-windows: Add annotations for OvsReleaseEventQueueLock f05dc2c26e8c datapath-windows: Add function annotations for OvsAcquireEventQueueLock 7fba23033f21 datapath-windows: Add function annotations for OvsCancelIrpDatapath 8ba92ebee99d datapath-windows: Add function annotations for OvsTunnelFilterCancelIrp 5f0d140d127d datapath-windows: Add function annotations for OvsCancelIrp 5635920bb4ea datapath-windows: Add function annotations for OvsReleaseDatapath 41d18c494a7b datapath-windows: Add function annotations for OvsAcquireDatapathWrite 3e6d3fe13bdd datapath-windows: Add function annotations for OvsAcquireDatapathRead 9330795b9790 datapath-windows: Remove function declarations from Tunnel.c 3cbbcb1ba611 datapath-windows: Add annotations for OvsReleaseCtrlLock 9f6573fe07db datapath-windows: Add annotations for OvsAcquireCtrlLock 9264367cd549 datapath-windows: Add an assert in recirculation 5a3cb5148f1e datapath-windows: Fix possible NULL dereference in BufferMgmt 1919e76d6b8e datapath-windows: Suppress PAGED_CODE warnings b0586ec79b48 datapath-windows: Add asserts to Stt d82c1ff1dbd7 datapath-windows: Fix code alignment in Stt 4f967565aed2 datapath-windows: interfaceName overflow in IpHelper 043b1405b50a datapath-windows: Remove annotations in Switch.c fe09b60d4923 datapath-windows: Use non-executable memory when allocating memory Can you be more specific about the problems? Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
