Hi Greg, Thanks for your review and testing. I will incorporate all your reviews, rebase, and send out a v2 soon.
Best, -Yi-Hung On Thu, Aug 31, 2017 at 2:15 PM, Greg Rose <[email protected]> wrote: > On 08/25/2017 03:51 PM, Yi-Hung Wei wrote: >> >> This patch series add support of querying conntrack info that includes >> ct_state, ct_mark, and ct_label from kernel datapath. This work first >> introduces ct_dpif_get_info() in dpif layer, and then provides netlink >> implementation of ct_dpif_get_info(). It also updates the --ct-next >> command line option of ofproto/trace to let users specify the supported >> conntrack fields. >> >> Yi-Hung Wei (9): >> ofproto/trace: Fix memory leak in oftrace_push_ct_state() >> ofproto/trace: Propagate ct_zone in recirculation >> ct-dpif: Add ct_dpif_get_info() >> ofproto/trace: Query ct_state for conntrack recirc from DP >> dpif-netlink: Implement ct_get_info >> netlink-conntrack: Add support for querying conntrack exp >> flow: Refactor parse_ct_state() >> ofproto/trace: Change delimiter of ct_state in --ct-next >> ofproto/trace: Support ct_mark and ct_label in --ct-next >> >> lib/ct-dpif.c | 68 +++++++ >> lib/ct-dpif.h | 25 +++ >> lib/dpif-netdev.c | 1 + >> lib/dpif-netlink.c | 9 + >> lib/dpif-provider.h | 8 + >> lib/flow.c | 6 +- >> lib/flow.h | 2 +- >> lib/netlink-conntrack.c | 412 >> +++++++++++++++++++++++++++++++++++++++ >> lib/netlink-conntrack.h | 5 + >> lib/odp-util.c | 3 +- >> lib/odp-util.h | 1 + >> ofproto/ofproto-dpif-trace.c | 151 +++++++++----- >> ofproto/ofproto-dpif-trace.h | 10 +- >> ofproto/ofproto-dpif-xlate.c | 7 +- >> ofproto/ofproto-unixctl.man | 16 +- >> ovn/utilities/ovn-trace.c | 2 +- >> tests/atlocal.in | 3 + >> tests/ofproto-dpif.at | 18 +- >> tests/system-kmod-macros.at | 6 + >> tests/system-traffic.at | 318 ++++++++++++++++++++++++++++++ >> tests/system-userspace-macros.at | 9 + >> 21 files changed, 1005 insertions(+), 75 deletions(-) >> > I've applied this patch series and ran the system traffic tests which all > passed. The patch series as applied atop master from commit e8b91cf36769 " > Merge branch 'dpdk_merge' of https://github.com/darball/ovs." passes a > travis build check. > > Tested-by: Greg Rose <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
