On Tue, Aug 29, 2017 at 07:29:57AM +0300, Roi Dayan wrote:
> From: Paul Blakey <[email protected]>
> 
> Currently we test the tunnel id value and not the mask so matching on
> tunnel id 0 is skipped and we fail to offload the rule with an
> unknown attribute error.
> 
> Fix this by testing the mask of tunnel id instead.
> 
> Fixes: 8f283af89298 ("netdev-tc-offloads: Implement netdev flow put using tc 
> interface")
> Signed-off-by: Paul Blakey <[email protected]>
> Reviewed-by: Roi Dayan <[email protected]>

Acked-by: Simon Horman <[email protected]>

> ---
>  lib/netdev-tc-offloads.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c
> index 099c021..ba7a873 100644
> --- a/lib/netdev-tc-offloads.c
> +++ b/lib/netdev-tc-offloads.c
> @@ -678,7 +678,7 @@ netdev_tc_flow_put(struct netdev *netdev, struct match 
> *match,
>  
>      memset(&flower, 0, sizeof flower);
>  
> -    if (tnl->tun_id) {
> +    if (mask->tunnel.tun_id) {
>          VLOG_DBG_RL(&rl,
>                      "tunnel: id %#" PRIx64 " src " IP_FMT
>                      " dst " IP_FMT " tp_src %d tp_dst %d",
> -- 
> 2.7.0
> 
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to