On 09/08/2017 10:59 AM, Bhanuprakash Bodireddy wrote:
By reordering elements in dummy_packet_stream structure, sum holes

Do you mean "the sum of the holes" can be reduced or do you mean "some holes"
can be reduced?

Same question through several of the other patches where you use the same
language.

Thanks,

- Greg

can be reduced, thus saving a cache line.

Before: structure size: 784, sum holes: 56, cachelines:13
After : structure size: 768, sum holes: 40, cachelines:12

Signed-off-by: Bhanuprakash Bodireddy <[email protected]>
---
  lib/netdev-dummy.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
index f731af1..d888c40 100644
--- a/lib/netdev-dummy.c
+++ b/lib/netdev-dummy.c
@@ -50,8 +50,8 @@ struct reconnect;
struct dummy_packet_stream {
      struct stream *stream;
-    struct dp_packet rxbuf;
      struct ovs_list txq;
+    struct dp_packet rxbuf;
  };
enum dummy_packet_conn_type {


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to