On 09/13/2017 05:36 AM, [email protected] wrote:
ct_dpif_entry_uninit could potentially be called even if
ct_dpif_dump_next failed. As ct_dpif_entry_uninit receives
a pointer to a CT entry - and just checks it is not null -
it's safer to init to zero any instantiated ct_dpif_entry
variable before its usage.
Signed-off-by: Antonio Fischetti <[email protected]>
---
lib/dpctl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/dpctl.c b/lib/dpctl.c
index 86d0f90..77d4e58 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -1287,6 +1287,7 @@ dpctl_dump_conntrack(int argc, const char *argv[],
return error;
}
+ memset(&cte, 0, sizeof(cte));
while (!(ret = ct_dpif_dump_next(dump, &cte))) {
struct ds s = DS_EMPTY_INITIALIZER;
@@ -1392,6 +1393,7 @@ dpctl_ct_stats_show(int argc, const char *argv[],
return error;
}
+ memset(&cte, 0, sizeof(cte));
int tot_conn = 0;
while (!(ret = ct_dpif_dump_next(dump, &cte))) {
ct_dpif_entry_uninit(&cte);
@@ -1532,6 +1534,7 @@ dpctl_ct_bkts(int argc, const char *argv[],
return 0;
}
+ memset(&cte, 0, sizeof(cte));
dpctl_print(dpctl_p, "Total Buckets: %d\n", tot_bkts);
int tot_conn = 0;
Not in the hotpath so OK to be extra careful here.
Reviewed-by: Greg Rose <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
