Looks good to me. On Sat, Oct 28, 2017 at 12:34 PM William Tu <[email protected]> wrote:
> Clang reports possible optarg as null pointer passed to atoi. > Fix it by adding ovs_assert check before. > > Signed-off-by: William Tu <[email protected]> > Acked-by: Mark Michelson <[email protected]> > --- > utilities/ovs-appctl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/utilities/ovs-appctl.c b/utilities/ovs-appctl.c > index 8f87cc4f6c6e..cc1326bc9478 100644 > --- a/utilities/ovs-appctl.c > +++ b/utilities/ovs-appctl.c > @@ -165,6 +165,7 @@ parse_command_line(int argc, char *argv[]) > exit(EXIT_SUCCESS); > > case 'T': > + ovs_assert(optarg); > time_alarm(atoi(optarg)); > break; > > -- > 2.7.4 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
