Thanks for the review. Guru and I had some offline discussion. We have concern about possible packet lost when unconditionally remove the interface and bring it again. Currently if the userspace ovs-vswitchd dies, since the kernel datapath module still remains, packets can still go through. If restarting ovs-vswitch restarts the geneve device, then we might see more packets lost. So I'm thinking about another way to fix it without deleting the device.
Thanks William On Thu, Oct 26, 2017 at 1:20 PM, Eric Garver <[email protected]> wrote: > On Thu, Oct 26, 2017 at 12:31:03PM -0700, William Tu wrote: >> When using the out-of-tree (openvswitch compat) geneve module, >> the first time oot tunnel probing returns true (correct). >> Without unloading the geneve module, if the userspace ovs-vswitchd >> restarts, because the 'geneve_sys_6081' still exists, the probing >> incorrectly returns false and loads the in-tree (upstream kernel) >> geneve module. The issue also exists the other way around, where >> existing geneve module is in-tree and ovs-vswitchd restarts. >> >> The patch fixes it by unconditionally removing the tunnel device >> before the probing. To reproduce the issue, start the ovs >> > /etc/init.d/openvswitch-switch start >> > creat a bridge and attach a geneve port using out-of-tree geneve >> > /etc/init.d/openvswitch-switch restart >> >> Fixes: 921c370a9df5 ("dpif-netlink: Probe for out-of-tree tunnels, decides >> used interface") >> Signed-off-by: William Tu <[email protected]> >> Cc: Eric Garver <[email protected]> >> Cc: Gurucharan Shetty <[email protected]> >> --- >> lib/dpif-netlink-rtnl.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/lib/dpif-netlink-rtnl.c b/lib/dpif-netlink-rtnl.c >> index 0c32e7d8ccb4..148ce5ff3a3d 100644 >> --- a/lib/dpif-netlink-rtnl.c >> +++ b/lib/dpif-netlink-rtnl.c >> @@ -448,6 +448,8 @@ dpif_netlink_rtnl_probe_oot_tunnels(void) >> } >> >> name = netdev_vport_get_dpif_port(netdev, namebuf, sizeof namebuf); >> + dpif_netlink_rtnl_destroy(name); >> + >> error = dpif_netlink_rtnl_create(tnl_cfg, name, >> OVS_VPORT_TYPE_GENEVE, >> "ovs_geneve", >> (NLM_F_REQUEST | NLM_F_ACK >> -- >> 2.7.4 > > Thanks for the fix! > > Acked-by: Eric Garver <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
