On Tue, Aug 29, 2017 at 03:27:53PM -0700, Han Zhou wrote: > Add parameters in local Open_vSwitch DB external-ids for rate- > limiting the log file writing: > ovn-acl-log-rl-rate > ovn-acl-log-rl-burst > > Note: this has nothing to do with packet-in rate-limiting. > Signed-off-by: Han Zhou <[email protected]>
Thanks for working on this. Justin is probably the right person to review this, but here are a few preliminary comments. I'd prefer to see a new vlog_rate_limit_set() function, which could do the actual work of changing the rate limit. This is partly just to improve the abstraction, but also partly because vlog_rate_limit contains a mutex that should be taken whenever its data is accessed. I don't think that thread safety is a problem in this particular case, but I don't know of a downside to being careful here. The commit message doesn't explain the change to tests/automake.mk. In acl-log.h, we normally write prototypes without a line break. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
