On 10/31/2017 10:37 AM, Ben Pfaff wrote:
On Tue, Oct 31, 2017 at 10:08:08AM -0700, Greg Rose wrote:
On 10/24/2017 03:19 PM, Ben Pfaff wrote:
On Tue, Jun 06, 2017 at 01:42:08PM -0700, Greg Rose wrote:
On 06/06/2017 08:22 AM, Ben Pfaff wrote:
On Mon, Jun 05, 2017 at 08:34:32PM -0700, Greg Rose wrote:
On 06/05/2017 06:04 PM, Ben Pfaff wrote:
From: Greg Rose <gvrose8...@gmail.com>
Reported-by: Felix Konstantin Maurer <felix.mau...@comsys.rwth-aachen.de>
Signed-off-by: Greg Rose <gvrose8...@gmail.com>
[b...@ovn.org changed this to use ipfix_now()]
Signed-off-by: Ben Pfaff <b...@ovn.org>
---
ofproto/ofproto-dpif-ipfix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.c
index 5589b0ea05e1..bc63b7b0294b 100644
--- a/ofproto/ofproto-dpif-ipfix.c
+++ b/ofproto/ofproto-dpif-ipfix.c
@@ -1643,6 +1643,7 @@ ipfix_cache_update(struct dpif_ipfix_exporter *exporter,
ipfix_cache_aggregate_entries(entry, old_entry);
free(entry);
ipfix_update_stats(exporter, false, current_flows, sampled_pkt_type);
+ old_entry->flow_end_timestamp_usec = ipfix_now();
}
}
Looks good, thanks Ben!
Thanks for the review!
If I recall correctly, Felix reported that your original patch didn't
help, though, so probably this one doesn't either. We should track that
down before we go farther, I guess.
Yes, I'm am following up. Having all sorts of problems getting a working ipfix
flow collector to work though. The ManageEngine netflow collector claims to
work with ipfix but SFAICT it does not so I'm not going to waste more time on
it. Once I can start
collecting and analyzing the work should proceed quickly.
I never applied this patch (from June) because we were continuing to
look deeper. I don't know whether that ever bore fruit. Should I apply
this patch now?
Thanks,
Ben.
I think this one got lost. I never followed up on it and got busy with other
more pressing issues.
Should it get revived?
Well, when I think about it I have been using ipfix for quite a while
and I haven't seen any timestamp issues. So unless we see a reported
bug I'd hold off.
Thanks,
- Greg
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
