On Thu, Oct 26, 2017 at 01:09:01PM -0500, Mark Michelson wrote: > There are a couple of places in ovn-northd that set the "peer" option on > certain ports to "<error>" in certain cases. In every case where a peer is > looked up on a port binding, the code performs a NULL check in order to > ensure a peer exists. None check for the "<error>" string. They assume that > the > presence of a peer string means a peer is defined and all is well. > > In the past (OVS 2.6 series), this sometimes led to patch ports being created > in ovs that had names like "patch-ro-to-<error>". This particular problem > resolved itself in OVS 2.7 since such patch ports were no longer automatically > created. However, by naming the peer "<error>" the seeds are still sown for > similar issues to occur. > > The solution this patch suggests is to no longer set the "peer" option > on a port binding to "<error>". Instead, if no peer can be set, then we > set no peer. Since other code is already equipped to deal with this, > this poses no problem. > > Signed-off-by: Mark Michelson <[email protected]>
Thanks for the improvement! I applied this to master. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
