On Thu, Nov 2, 2017 at 5:51 AM, Alin Serdean <[email protected]> wrote: > > >> -----Original Message----- >> From: Ben Pfaff [mailto:[email protected]] >> Sent: Tuesday, October 31, 2017 9:34 PM >> To: Xiao Liang <[email protected]>; Alin Serdean >> <[email protected]> >> Cc: [email protected] >> Subject: Re: [ovs-dev] [PATCH 2/2] lib: Move lib/poll-loop.h to >> include/openvswitch >> >> On Thu, Aug 17, 2017 at 12:06:25AM +0800, Xiao Liang wrote: >> > Poll-loop is the core to implement main loop. It should be available >> > in libopenvswitch. >> > >> > Signed-off-by: Xiao Liang <[email protected]> >> >> I'm concerned about the way that this adds a definition of HANDLE in a public >> header. That seems unfriendly to code that might want to include both this >> header and Win32 headers that properly define HANDLE. >> >> Alin, what's the right thing to do here? > [Alin Serdean] First the type definition is wrong (HANDLE is VOID*). > I would avoid adding the definition to HANDLE. Maybe add an include to > <windows.h> or <windefs.h> to include/windows/poll.h .
Since include/windows is not installed as public header, is it safe to remove inclusion of poll.h and add windows.h in poll-loop.h? _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
