On Thu, Nov 02, 2017 at 02:50:13PM +0000, Mark Michelson wrote: > On Wed, Nov 1, 2017 at 4:38 PM Ben Pfaff <[email protected]> wrote: > > > On Wed, Oct 18, 2017 at 11:53:49AM -0500, Mark Michelson wrote: > > > This change adds three new options to the Northbound > > > Logical_Router_Port's ipv6_ra_configs option: > > > > > > * send_periodic: If set to "true", then OVN will send periodic router > > > advertisements out of this router port. > > > * max_interval: The maximum amount of time to wait between sending > > > periodic router advertisements. > > > * min_interval: The minimum amount of time to wait between sending > > > periodic router advertisements. > > > > > > When send_periodic is true, then IPv6 RA configs, as well as some layer > > > 2 and layer 3 information about the router port, are copied to the > > > southbound database. From there, ovn-controller can use this information > > > to know when to send periodic RAs and what to send in them. > > > > > > Because periodic RAs originate from each ovn-controller, the new > > > keep-local flag is set on the packet so that ports don't receive an > > > overabundance of RAs. > > > > > > Signed-off-by: Mark Michelson <[email protected]> > > > > Thanks a lot for working on this. It addresses a feature we've been > > missing for a long time. > > > > I get several application failures: > > > > Applying: OVN: Add support for periodic router advertisements. > > error: patch failed: ovn/controller/pinctrl.c:88 > > error: ovn/controller/pinctrl.c: patch does not apply > > error: patch failed: ovn/northd/ovn-northd.c:4375 > > error: ovn/northd/ovn-northd.c: patch does not apply > > error: patch failed: ovn/ovn-nb.xml:1369 > > error: ovn/ovn-nb.xml: patch does not apply > > Patch failed at 0001 OVN: Add support for periodic router > > advertisements. > > > > Would you mind rebasing and reposting? Thanks a lot. > > > > Thanks for having a look Ben. > > I'm not sure if you saw, but in the cover letter for this patchset, I > mentioned that it was dependent on Numan Siddique's patchset that adds > support for responses to router solicitations, etc (I provided the series > ID from patchwork). If that patchset was not applied before this one, then > there would be lots of errors when attempting to patch, and even more when > attempting to compile.
I didn't notice that. OK. > That being said, I will need to rebase and repost again anyway, because > Numan's patchset has been updated and reposted today. I also need to make > the manpage adjustments that you suggested for patch 1. I'll get that done > as soon as I can. OK. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
