Thanks for all your advice. I will pay close attention next time. On Thu, Nov 2, 2017 at 2:14 PM, Ben Pfaff <[email protected]> wrote:
> On Tue, Oct 31, 2017 at 10:52:08AM -0700, Yifeng Sun wrote: > > Valgrind testcase 2339 (ovn -- ipam connectivity) reports the leak below: > > 45 (32 direct, 13 indirect) bytes in 1 blocks are definitely lost in > loss record 65 of 83 > > at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_ > memcheck-amd64-linux.so) > > by 0x4A6D64: xmalloc (util.c:120) > > by 0x49C847: shash_add_nocopy__ (shash.c:109) > > by 0x49C847: shash_add_nocopy (shash.c:121) > > by 0x49CA85: shash_add (shash.c:129) > > by 0x49CA85: shash_add_once (shash.c:136) > > by 0x4914B5: ovsdb_idl_create_index (ovsdb-idl.c:2067) > > by 0x406C98: create_ovnsb_indexes (ovn-controller.c:568) > > by 0x406C98: main (ovn-controller.c:619) > > > > The leak happens when vsdb_idl_table is freed but its indexes are not > freed. > > > > v1->v2: Amend comments. > > v2->v3: Fix error in patch. > > > > Signed-off-by: Yifeng Sun <[email protected]> > > Thanks! I'll apply this to master soon. > > Please don't put the changes from one version to the next into the > commit message, because they should not go into the repository. They > can go after the --- line in the email; you can even put a --- line into > the commit message and put them after it, if you prefer. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
