On Fri, Sep 08, 2017 at 06:59:21PM +0100, Bhanuprakash Bodireddy wrote: > By reordering elements in dpif_flow_put structure, holes can be removed. > > Before: structure size: 80, sum holes: 8, cachelines:2 > After : structure size: 72, sum holes: 0, cachelines:2 > > Signed-off-by: Bhanuprakash Bodireddy <[email protected]>
Thanks for the patch. This is one case where I don't think the change is worth it. The structure is a little smaller, but this structure is generally on the stack and often part of union dpif_op, and I think that moving pmd_id to the beginning of the struct makes it look more important than it is. So, I'm going to skip this one. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
