Thank you for the comments. We will incorporate your suggestion in V3.
> -----Original Message----- > From: Ben Pfaff [mailto:[email protected]] > Sent: Friday, November 3, 2017 10:57 AM > To: Wang, Yipeng1 <[email protected]> > Cc: [email protected] > Subject: Re: [ovs-dev] [PATCH v2 5/5] unit-test: Add a delay for CD > initialization. > > On Tue, Oct 31, 2017 at 04:39:37PM -0700, Yipeng Wang wrote: > > This patch adds a delay during test 1215 for considering CD > > initialization time. > > > > CC: Darrell Ball <dball at vmware.com> > > CC: Jan Scheurich <jan.scheurich at ericsson.com> > > Signed-off-by: Yipeng Wang <yipeng1.wang at intel.com> > > Signed-off-by: Antonio Fischetti <antonio.fischetti at intel.com> > > Co-authored-by: Antonio Fischetti <antonio.fischetti at intel.com> > > --- > > tests/ofproto-dpif.at | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at > > index c75a1ac..8b55454 100644 > > --- a/tests/ofproto-dpif.at > > +++ b/tests/ofproto-dpif.at > > @@ -9596,6 +9596,9 @@ AT_CHECK([ovs-ofctl add-flows br0 flows.txt]) > > dnl Start a new connection from port 1. > > AT_CHECK([ovs-appctl netdev-dummy/receive p1 > 'in_port(1),eth(src=50:54:00:00:00:09,dst=50:54:00:00:00:0a),eth_type(0x080 > 0),ipv4(src=10.1.1.1,dst=10.1.1.2,proto=17,tos=0,ttl=64,frag=no),udp(src=1,d > st=2)']) > > > > +# cuckoo distributor requires time for initilization, add sleep > > +sleep 2 > > + > > If it's not too hard, it would be better to add an ovs-appctl command to > wait until the cuckoo distributor is ready. > > In commit messages, when practical, it's better to refer to tests by > their name instead of number, or in addition to number, because the > numbers shift from one commit to the next. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
