On Fri, Nov 10, 2017 at 06:02:17AM +0900, Gregory Rose wrote: > > On 11/9/2017 9:34 PM, Ilya Maximets wrote: > >Since 57eebbb4c315, the caller must make sure that 'netdev' supports > >sending. This mentioned at the start of the comment. > > > >Fixes: 57eebbb4c315 ("dpif-netdev: Don't try to output on a device without > >txqs.") > >Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> > >--- > > lib/netdev.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > >diff --git a/lib/netdev.c b/lib/netdev.c > >index 704b38f..3c6fbfa 100644 > >--- a/lib/netdev.c > >+++ b/lib/netdev.c > >@@ -784,10 +784,7 @@ netdev_get_pt_mode(const struct netdev *netdev) > > * transmission queues, so that the caller does not ordinarily have to > > * do additional queuing of packets. 'qid' specifies the queue to use > > * and can be ignored if the implementation does not support multiple > >- * queues. > >- * > >- * Some network devices may not implement support for this function. In > >such > >- * cases this function will always return EOPNOTSUPP. */ > >+ * queues. */ > > int > > netdev_send(struct netdev *netdev, int qid, struct dp_packet_batch *batch, > > bool may_steal, bool concurrent_txq) > > Right. > > Reviewed-by: Greg Rose <gvrose8...@gmail.com>
Thanks Ilya and Greg, I applied this to master. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev