On 13 November 2017 at 06:43, William Tu <[email protected]> wrote:
> On Fri, Nov 10, 2017 at 2:45 PM, Gurucharan Shetty <[email protected]> wrote: > > From OVS 2.8, ovs-vswitchd, when it starts, will > > load the kernel modules for tunnels. It has logic > > inside it to choose either upstream kernel module > > or vport-* kernel module. > > > > So, when we run 'force-reload-kmod' to upgrade to > > OVS 2.8 from a previous version, we do not need to > > remember the vport-* kernel module that was previously > > loaded. It is not really harmful to load vport-* kernel > > module though. > > > > On RHEL7.x and OVS 2.8, we use the upstream "geneve" kernel > > module for tunnels. > > > > But, on RHEL 7.x we have hit a bug caused by iptables > > startup script which tries to remove all kernel modules > > related to linux conntrack. It fails to unload openvswitch > > kernel module because it has a reference count on it. But it > > succeeds in unloading vport-geneve and in turn the upstream > > "geneve" kernel module. This causes the tunnels to go down. > > > > With this patch, we avoid the above situation, by not loading > > vport-geneve kernel module. ovs-vswitchd when it starts will > > load upstream geneve. And when "iptables stop" runs, since > > "geneve" has nothing to do with conntrack, it spares it. > > Ideally, we should fix this by incrementing the refcount > > on the kernel modules. > > > > Signed-off-by: Gurucharan Shetty <[email protected]> > > --- > Looks good to me. > > Acked-by: William Tu <[email protected]> > Thanks William. I applied this to master and 2.8 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
