On Thu, Nov 16, 2017 at 09:42:20AM -0500, Aaron Conole wrote:
> Ben Pfaff <[email protected]> writes:
> 
> > Perl is unfashionable and Python is more widely available and understood,
> > so this commit converts one of the OVS uses of Perl into Python.
> >
> > Signed-off-by: Ben Pfaff <[email protected]>
> > +def find_file(include_dirs, name):
> > +    for dir in include_dirs:
> > +        file = "%s/%s" % (dir, name)
> > +        try:
> > +            os.stat(file)
> > +            return file
> > +        except OSError as e:
> 
> This should just be 'except OSError'.

Thanks, fixed here and in soexpand.

> There looks to be a bit of overlap between this and sodepends and
> dpdkstrip.  Maybe it's worthwhile to introduce a build-aux.py that these
> tools import?

It's a reasonable request.  I'll send a v2.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to