On Wed, Nov 29, 2017 at 05:13:14PM -0800, Sairam Venugopal wrote: > Found when compiling the code with C++ binaries. Most of the issues are > due to missing explicit cast. > > Signed-off-by: Sairam Venugopal <[email protected]> > Signed-off-by: Shireesh Kumar Singh <[email protected]> > Co-authored-by: Shireesh Kumar Singh <[email protected]>
Hi Sairam, thanks for passing this along. The commit message does not explain the problem with PADDED_MEMBERS_CACHELINE_MARKER. Can you help me to understand it? The reason I would expect to add a new MSVC-only version is that it is impossible to write a single version (for C) that works with MSVC, GCC, and Clang, but I don't yet know a reason that is true. The header files in lib/ aren't exported for public consumption, which means that software other than Open vSwitch itself isn't expected to use them. Of course, VMware and possibly others are actually doing that. I have mixed feelings about that. It's nice to know that OVS has useful header files, but I'm not so excited about the idea that every OVS header file has to work OK in C++. Do you have any thoughts on how an OVS developer can guess whether a given header file will be used in C++? _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
