On Mon, Dec 04, 2017 at 08:32:28AM -0800, Gregory Rose wrote: > On 11/30/2017 10:38 AM, Ben Pfaff wrote: > >Reported-by: Shivaram Mysore <[email protected]> > >Signed-off-by: Ben Pfaff <[email protected]> > >--- > > Documentation/howto/sflow.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/Documentation/howto/sflow.rst b/Documentation/howto/sflow.rst > >index 1152a7db567a..66f4856b3340 100644 > >--- a/Documentation/howto/sflow.rst > >+++ b/Documentation/howto/sflow.rst > >@@ -105,7 +105,7 @@ Still on `host1`, run the following command to create an > >sFlow configuration > > and attach it to bridge br0:: > > $ ovs-vsctl -- --id=@sflow create sflow agent=${AGENT_IP} \ > >- target="${COLLECTOR_IP}:${COLLECTOR_PORT}" header=${HEADER_BYTES} \ > >+ target='"${COLLECTOR_IP}:${COLLECTOR_PORT}"' header=${HEADER_BYTES} > >\ > > sampling=${SAMPLING_N} polling=${POLLING_SECS} \ > > -- set bridge br0 sflow=@sflow > > Looks good. > > Reviewed-by: Greg Rose <[email protected]> >
Thanks, applied to master. I changed '"..."' to "\"...\"" because I realized that using '"..."' will prevent the intended shell variable expansion. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
