>> On Nov 21, 2017, at 5:00 PM, Yi-Hung Wei <[email protected]> wrote:
>>
>> This patch adds support of flushing a conntrack entry specified by the
>> conntrack 5-tuple, and provides the implementation in dpif-netlink.
>> The implementation of dpif-netlink in the linux datapath utilizes the
>> NFNL_SUBSYS_CTNETLINK netlink subsystem to delete a conntrack entry in
>> nf_conntrack.
>
> It would be good to mention that this patch doesn't support the userspace or
> Windows datapaths. I'd like to add the following sentence to the commit
> message:
>
> Future patches will add support for the userspace and Windows
> datapaths.
Sure.
>
>> diff --git a/lib/netlink-conntrack.c b/lib/netlink-conntrack.c
>> index 1e1bb2f79d1d..1f0b9121036d 100644
>> --- a/lib/netlink-conntrack.c
>> +++ b/lib/netlink-conntrack.c
>>
>> ...
>> +int
>> +nl_ct_flush_tuple(const struct ct_dpif_tuple *tuple, uint16_t zone)
>> +{
>> + int err;
>> + struct ofpbuf buf;
>> +
>> + ofpbuf_init(&buf, NL_DUMP_BUFSIZE);
>> + nl_msg_put_nfgenmsg(&buf, 0, tuple->l3_type, NFNL_SUBSYS_CTNETLINK,
>> + IPCTNL_MSG_CT_DELETE, NLM_F_REQUEST);
>> +
>> + nl_msg_put_be16(&buf, CTA_ZONE, htons(zone));
>
> When reviewing this patch, I noticed an issue with how Windows was handling
> conntrack zones for flush. I sent out a patch:
>
>
> https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341610.html
>
> It's not a blocker for this patch, since this series doesn't add support for
> flushing by 5-tuple on Windows. However, I wanted to point out that it will
> need to be fixed before that support is added.
>
> I thought a couple of the function descriptions could be clearer with a bit
> more formatting and slight changes to the text. I've appended those as a
> patch to this message.
>
> If you agree with my suggestions, I'll commit this patch with those changes.
>
> Thanks,
>
> --Justin
Thanks for the review. Please fold in the changes, it makes the
function descriptions much clearer.
Thanks,
-Yi-Hung
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
