Hi Ilya, Thank you for the comments, I try to refactor the code according to them.
Regards, Robert -----Original Message----- From: Ilya Maximets [mailto:[email protected]] Sent: Wednesday, December 06, 2017 12:40 PM To: [email protected]; Róbert Mulik <[email protected]> Subject: Re: [ovs-dev] [PATCH] Configurable Link State Change (LSC) detection mode Hi Robert. Few general comments: If you'll move per-interface config from 'other_config' to 'options' column, you'll be able to localize code changes to only dpdk.c and netdev-dpdk.c. The changes in all other code files are redundant especially because the option could only affect dpdk ports. The second vote for 'options' is that all other interface configuration options like number of RX/TX queues, descriptor ring sizes are located in 'options' not in 'other_config'. The third is that you'll be able to add proper 'area' prefix to you patch. It's really hard to recognize that this patch is about DPDK while looking at its name. Also, please, check you patch with ./utilities/checkpatch.py script. I see at least few too long lines. Check out coding-style.rst for details. Best regards, Ilya Maximets. > It is possible to set LSC detection mode to polling or interrupt mode > for DPDK interfaces. The default is polling mode. To set interrupt > mode, option dpdk-lsc-interrupt has to be set to true. > > > Global settings > Service restart is necessary for the global settings to take effect. > > Command to set interrupt mode for all interfaces: > ovs-vsctl set Open_vSwitch . other_config:dpdk-lsc-interrupt=true > > Command to set polling mode for all interfaces: > ovs-vsctl set Open_vSwitch . other_config:dpdk-lsc-interrupt=false > or: > ovs-vsctl remove Open_vSwitch . other_config dpdk-lsc-interrupt > > > Interface specific settings (override global settings) Service restart > is not necessary to take effect. > > Command to set interrupt mode for a specific interface: > ovs-vsctl set interface <interface_name> > other_config:dpdk-lsc-interrupt=true > > Command to set polling mode for a specific interface: > ovs-vsctl set interface <interface_name> > other_config:dpdk-lsc-interrupt=false > > Command to reset to globally defined mode for a specific interface: > ovs-vsctl remove interface <interface_name> other_config > dpdk-lsc-interrupt > > Signed-off-by: Robert Mulik <robert.mulik at ericsson.com> > --- > lib/dpdk.c | 6 ++++++ > lib/netdev-dpdk.c | 60 > ++++++++++++++++++++++++++++++++++++++++++++++++++- > lib/netdev-dpdk.h | 8 +++++++ > lib/netdev-dummy.c | 2 ++ > lib/netdev-linux.c | 2 ++ > lib/netdev-provider.h | 3 +++ > lib/netdev-vport.c | 2 ++ > lib/netdev.c | 32 +++++++++++++++++++++++++++ > lib/netdev.h | 2 ++ > vswitchd/bridge.c | 34 +++++++++++++++++++++++++++++ > vswitchd/vswitch.xml | 42 ++++++++++++++++++++++++++++++++++++ > 11 files changed, 192 insertions(+), 1 deletion(-) _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
