On 13.12.2017 12:27, Stephen Finucane wrote:
> On Tue, 2017-12-12 at 16:19 +0300, Ilya Maximets wrote:
>> In current version table contains only one row with all the values
>> together. This is not readable. 'Simple table' format should work for
>> this case.
>>
>> CC: Stephen Finucane <[email protected]>
>> Fixes: 167703d664fc ("doc: Convert INSTALL.DPDK to rST")
>> Signed-off-by: Ilya Maximets <[email protected]>
>
> Some suggestion for other, not-totally-related improvements below, but
> this looks good>
> Acked-by: Stephen Finucane <[email protected]>
>
>> ---
>> Documentation/howto/dpdk.rst | 22 ++++++++++++----------
>> 1 file changed, 12 insertions(+), 10 deletions(-)
>>
>> diff --git a/Documentation/howto/dpdk.rst
>> b/Documentation/howto/dpdk.rst
>> index d123819..763b237 100644
>> --- a/Documentation/howto/dpdk.rst
>> +++ b/Documentation/howto/dpdk.rst
>> @@ -531,16 +531,18 @@ Add test flows to forward packets betwen DPDK
>> devices and VM ports::
>>
>> Create a VM using the following configuration:
>>
>> -+----------------------+--------+-----------------+
>> -| configuration | values | comments |
>> -+----------------------+--------+-----------------+
>> -| qemu version | 2.2.0 | n/a |
>> -| qemu thread affinity | core 5 | taskset 0x20 |
>> -| memory | 4GB | n/a |
>> -| cores | 2 | n/a |
>> -| Qcow2 image | CentOS7| n/a |
>> -| mrg_rxbuf | off | n/a |
>> -+----------------------+--------+-----------------+
>> +.. table::
>> +
>> + ===================== ======== ============
>> + configuration values comments
>> + ===================== ======== ============
>> + qemu version 2.2.0 n/a
>> + qemu thread affinity core 5 taskset 0x20
>> + memory 4GB n/a
>> + cores 2 n/a
>
> We might want to capitalize these while we're at it.
>
> QEMU version
> Memory
> ...
>
OK. Thanks for suggestion. It looks really better with capital letters.
I'll send v2 with that change. I'll also capitalize table headers:
configuration --> Configuration
...
This will make table conform with other tables in the file.
Best regards, Ilya Maximets.
P.S. I'll keep your Acked-by for v2 if you do not mind.
>> + Qcow2 image CentOS7 n/a
>> + mrg_rxbuf off n/a
>> + ===================== ======== ============
>>
>> You can do this directly with QEMU via the ``qemu-system-x86_64``
>> application::
>>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
