On Wed, Dec 20, 2017 at 02:45:36PM -0800, Justin Pettit wrote: > > > > On Dec 13, 2017, at 3:10 PM, Ben Pfaff <[email protected]> wrote: > > > > > > diff --git a/ovsdb/ovsdb-client.1.in b/ovsdb/ovsdb-client.1.in > > index 30de9c536600..70529a1e6600 100644 > > --- a/ovsdb/ovsdb-client.1.in > > +++ b/ovsdb/ovsdb-client.1.in > > @@ -27,6 +27,8 @@ ovsdb\-client \- command-line interface to > > \fBovsdb-server\fR(1) > > .IP "Data Management Commands:" > > \fBovsdb\-client \fR[\fIoptions\fR] \fBtransact\fI \fR[\fIserver\fR] > > \fItransaction\fR > > .br > > +\fBovsdb\-client \fR[\fIoptions\fR] \fBquery\fI \fR[\fIserver\fR] > > \fItransaction\fR > > +.br > > Same comment about unnecessary "\f*".
Thanks, fixed. > > @@ -137,6 +139,15 @@ which must be a JSON array appropriate for use as the > > \fBparams\fR to > > a JSON-RPC \fBtransact\fR request, and prints the received reply on > > stdout. > > . > > +.IP "\fBquery\fI \fR[\fIserver\fR] \fItransaction\fR" > > Ditto. Thanks, fixed. > > +Connects to \fIserver\fR, sends it the specified \fItransaction\fR, > > +which must be a JSON array appropriate for use as the \fBparams\fR to > > +a JSON-RPC \fBtransact\fR request, and prints the received reply on > > +stdout. To ensure that the transaction does not modify the database, > > +this command appends an \fBabort\fR operation to the set of operations > > +included in \fItransaction\fR before sending it to the database, and > > +then removes the \fBabort\fR result from the reply (if it is present). > > It seems that the only difference between "transact" and "query" is that > "query" is read-only. The man page descriptions are slightly different > between the commands, so it wasn't immediately obvious that was the only > difference. It might be worth making it a bit more concrete--possibly even > by directly referencing "transact" from this description. That is a good idea. I added: "This commands acts like a read-only version of \fBtransact\fR." > Acked-by: Justin Pettit <[email protected]> Thank you for the review. I applied this to master. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
