> On Dec 22, 2017, at 12:49 PM, Ben Pfaff <[email protected]> wrote:
>
> On Thu, Dec 21, 2017 at 04:18:05PM -0800, Justin Pettit wrote:
>>
>>
>>> On Dec 8, 2017, at 12:53 PM, Ben Pfaff <[email protected]> wrote:
>>>
>>> + if (argc > 2 && argv[1][0] == '_') {
>>> + unixctl_command_reply_error(conn, "cannot compact built-in
>>> databases");
>>> + return;
>>> + }
>>
>> This error condition seems a little odd to me. I think it will only provide
>> this warning if multiple databases are specified, and only complain if the
>> first one is built-in.
>
> You're right, there's a bug here, and I didn't test it. Shame on me.
>
> (However, the command supports at most one named database on the command
> line, which is part of the reason the test is somewhat odd.)
Oh, yeah, I see that now when I look at the command registration. I was thrown
off since I think the man page indicates multiple are supported:
ovsdb-server/compact [db]...
Compacts each database db in-place. If no db is specified, com‐
pacts every database in-place.
I sent out a patch to update the man page.
Thanks for the incremental patch; it looks good to me.
--Justin
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
