> On Dec 7, 2017, at 5:12 PM, Ben Pfaff <[email protected]> wrote: > > +/* Returns true if 'log' has grown enough above the base that it's worthwhile > + * to compact it, false otherwise. */ > +bool > +ovsdb_log_has_grown(const struct ovsdb_log *log)
This name seems a bit misleading, since it just sounds like it's just grown as opposed to grown to a sufficient size. What about something like ovsdb_log_should_compact()? > diff --git a/ovsdb/log.h b/ovsdb/log.h > index 4b74ca11ce6a..e68e922f871a 100644 > --- a/ovsdb/log.h > +++ b/ovsdb/log.h > @@ -16,6 +16,25 @@ > #ifndef OVSDB_LOG_H > #define OVSDB_LOG_H 1 > > +/* OVSDB log. > + * > + * A log consists of a series of records. After opening or creating a log > with > + * ovsdb_log_open(), the client may use ovsdb_log_read() to read any existing > + * records, one by one. The client may also use ovsdb_log_write() to write > new > + * records (if some records have not yet been read at this point, then the > + * first write truncates them). It might be nice to add some of this information to the functions themselves. Acked-by: Justin Pettit <[email protected]> --Justin _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
