On Tue, Jan 02, 2018 at 06:18:03PM +0100, Matteo Croce wrote: > On Tue, Jan 2, 2018 at 6:08 PM, Aaron Conole <[email protected]> wrote: > > Hi Matteo, > > > > Matteo Croce <[email protected]> writes: > > > >> Show DPDK version if Open vSwitch is compiled with DPDK support. > >> Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py > >> to populate the field with the right value. > >> > >> Signed-off-by: Matteo Croce <[email protected]> > >> --- > > > > Sorry I missed some of the development for this - I think it's better to > > have the dpdk version retrieved via an appctl command. I can't think of > > a need for this information to be persistent - if it's for historical > > information when debugging, we can put it in with the logs when dpdk is > > started. The user cannot influence DPDK version dynamically - it is not > > just read-only, but it's read-only from a compile time decision. I > > might be misunderstanding the point of putting this in the DB, though? > > Hi Aaron, > > I was threating dpdk_version the same way as ovs_version. > ovs_version is saved into the DB by ovs-ctl and it isn't read-only either. > What about putting it only in `ovs-vswitchd --version` output and not > into the DB?
One reason that ovs_version is in the database is because a controller might need to know and the controller can't necessarily run "ovs-vswitchd --version" since it might be on a different host. I don't know whether a controller needs to know the DPDK version. I assumed that it did and that that was the motivation for the commit. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
