On Tue, Jan 02, 2018 at 10:14:42AM -0800, Gregory Rose wrote: > On 1/2/2018 8:31 AM, Ben Pfaff wrote: > >Reported-by: Alan Kayahan <hsy...@gmail.com> > >Signed-off-by: Ben Pfaff <b...@ovn.org> > >--- > > Documentation/faq/contributing.rst | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > >diff --git a/Documentation/faq/contributing.rst > >b/Documentation/faq/contributing.rst > >index e4a37708fbca..d5226f4f7f7b 100644 > >--- a/Documentation/faq/contributing.rst > >+++ b/Documentation/faq/contributing.rst > >@@ -45,11 +45,11 @@ Q: How do I implement a new OpenFlow message? > > Q: How do I add support for a new field or header? > >- A: Add new members for your field to ``struct flow`` in ``lib/flow.h``, > >and > >- add new enumerations for your new field to ``enum mf_field_id`` in > >- ``include/openvswitch/meta-flow.h``, following the existing pattern. If > >- the field uses a new OXM class, add it to OXM_CLASSES in > >- ``build-aux/extract-ofp-fields``. Also, add support to > >+ A: Add new members for your field to ``struct flow`` in > >+ ``include/openvswitch/flow.h``, and add new enumerations for your new > >field > >+ to ``enum mf_field_id`` in ``include/openvswitch/meta-flow.h``, > >following > >+ the existing pattern. If the field uses a new OXM class, add it to > >+ OXM_CLASSES in ``build-aux/extract-ofp-fields``. Also, add support to > > ``miniflow_extract()`` in ``lib/flow.c`` for extracting your new field > > from > > a packet into struct miniflow, and to ``nx_put_raw()`` in > > ``lib/nx-match.c`` to output your new field in OXM matches. Then > > recompile > > LGTM > > Reviewed-by: Greg Rose <gvrose8...@gmail.com>
Thanks, applied to master. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev