> > Finally, the order of merging our patches matters. I'm sure my PMD > > performance metrics refactoring conflicts with both Ilya's and > Kevin's latest changes. I don't know which order will cause the least rework. > But we should decide on an order and work accordingly to > avoid unnecessary churn. > > Agree. We need to define the order to reduce amount of useless > rewriting/rebasing. > Right now, as I understand, all of our patch-sets needs rebasing on the > upcoming > pull request (simple output batching). > > Best regards, Ilya Maximets. >
I just submitted version v5 of "PMD performance metrics" rebased to master including Ilya's simple output batching. The manual rebasing is substantial each time. I would appreciate if we could get this patch merged as soon as possible so that we have a solid base for "Time-based output batching v9" and Kevin's rxq cycle series. To understand the size of the issue I am currently trying to manually merge Ilya's v9 on top of my v5. Again this is not a trivial undertaking. Especially the ad-hoc cycle counting logic for PMD and rxq stats is becoming a bit unwieldy, and calling for some systematic refactoring. I'm giving this some thoughts and intend to come back with a proposal for comments. Regards, Jan _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
