Hi guys, It would be great to get your feedback on the proposal for combining (and simplifying) our patches.
Do you agree with a) the cycle counting refactoring and b) the simplification of rxq pmd load calculation? For actual merge I would suggest to re-order the changes and take the cycle counting refactoring before the time-based output batching. But that is perhaps just a matter of taste affecting some intermediate commits and not so important for the end-result... How should we proceed with including these to the dpdk_merge branch? - One patch series at a time in the order now laid out in my RFC series - One large series comprising all 4 contributions? Regards, Jan > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of Jan > Scheurich > Sent: Thursday, 04 January, 2018 21:03 > To: [email protected] > Cc: Jan Scheurich <[email protected]> > Subject: [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches > > This RFC patch series contains three contributions: > > 1. A rebase of Ilya's series "[PATCH v9,0/5] Output packet batching > (Time-based)." > (http://patchwork.ozlabs.org/cover/852003/) on top of "[PATCH v5,0/3] > dpif-netdev: > Detailed PMD performance metrics and supervision" > (http://patchwork.ozlabs.org/cover/855572/). > > 2. Refactoring and simplification of the PMD cycle counting id dpif-netdev.c. > > 3. A rebase and simplification of Kevin's patches > (http://patchwork.ozlabs.org/patch/847972/) > to display PMD usage per queue in the ovs-appctl pmd-rxq-show command. > > The patches pass check_patch and "make check" and I have done some basic > tests of the > simplified rxq cycle counting and the PMD usage reporting in pmd-rxq-show. > > This is my proposal how to combine the three existing patch series together > with the > simplified cycle counting the into branch dpdk_merge for release in OSV 2.9. > > Before merging the last two patches should probably be combined. > > > Ilya Maximets (5): > dpif-netdev: Use microsecond granularity. > dpif-netdev: Count cycles on per-rxq basis. > dpif-netdev: Time based output batching. > docs: Describe output packet batching in DPDK guide. > NEWS: Mark output packet batching support. > > Jan Scheurich (2): > dpif-netdev: Refactor cycle counting > dpif-netdev: Add percentage of pmd/core used by each rxq. > > Kevin Traynor (1): > dpif-netdev: Reset the rxq current cycle counter on reload. > > Documentation/howto/dpdk.rst | 12 ++ > Documentation/intro/install/dpdk.rst | 58 ++++++ > NEWS | 3 + > lib/dpif-netdev.c | 350 > ++++++++++++++++++++++------------- > tests/pmd.at | 51 +++-- > vswitchd/vswitch.xml | 16 ++ > 6 files changed, 349 insertions(+), 141 deletions(-) > > -- > 1.9.1 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
