On Mon, Jan 08, 2018 at 11:36:22AM +0000, Zhenyu Gao wrote:
> 1. ovs cannot create two ports with same tunnel type and options:remote_ip
> 2. add santity check to detect if two chassises have same encap ip
> 3. add a sset to store tunnel ports' type & encap ip information
> 
> Signed-off-by: Zhenyu Gao <[email protected]>

Thanks for working on improving OVN.

This code leaks memory because it never destroys tunnel_type_ips.

I am unsure whether this handles changes properly.  Deletions happen
only at the end of encaps_run().  Insertions happen earlier.  What would
happen if a pass through encaps_run() was supposed to swap two tunnels
that would otherwise conflict?

Thanks,

Ben.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to