When ovn-controller detects that a flow is duplicated, it will print an INFO trace. Even though it's rate limited, this patch is changing the trace level back to DEBUG to reduce noise.
Signed-off-by: Daniel Alvarez <[email protected]> --- In our effort to ensure consistency across objects in Neutron and OVN databases we find some special cases like security group rules which match OVN ACLs but not in 1:1 relationship. Until now, two identical security group rules beloning each to a different security group would generate a single ACL in NB database. With this behavior, there's no way to map the ACL in OVN to the corresponding Neutron object. By implementing [0] we're trying to ensure this mapping so we make use of the external_ids column of every table for this purpose. It may happen that we'll have two identical ACLs but each referencing a different Neutron object in their external_ids field. However, this will make ovn-controller to drop those duplicated flows and log a (rate controlled) INFO trace. In order to reduce this noise, this patch changes it to DBG. [0] https://docs.openstack.org/networking-ovn/latest/contributor/design/database_consistency.html ovn/controller/ofctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ovn/controller/ofctrl.c b/ovn/controller/ofctrl.c index 90afddbb3..2fa980ebd 100644 --- a/ovn/controller/ofctrl.c +++ b/ovn/controller/ofctrl.c @@ -620,9 +620,9 @@ ofctrl_add_flow(struct hmap *desired_flows, if (ovn_flow_lookup(desired_flows, f)) { static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 5); - if (!VLOG_DROP_INFO(&rl)) { + if (!VLOG_DROP_DBG(&rl)) { char *s = ovn_flow_to_string(f); - VLOG_INFO("dropping duplicate flow: %s", s); + VLOG_DBG("dropping duplicate flow: %s", s); free(s); } -- 2.13.5 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
