Hi Ian, On 09/01/18 16:16, Stokes, Ian wrote: >> -----Original Message----- >> From: Markos Chandras [mailto:[email protected]] >> Sent: Tuesday, January 9, 2018 3:55 PM >> To: [email protected] >> Cc: Kavanagh, Mark B <[email protected]>; Ilya Maximets >> <[email protected]>; Stokes, Ian <[email protected]>; Markos >> Chandras <[email protected]> >> Subject: [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t >> >> From: Mark Kavanagh <[email protected]> >> >> netdev_dpdk_detach() declares a 'port_id' variable, of type uint8_t. >> This variable should instead be of type dpdk_port_t. > > Hi Markos, is there a specific reason you require this patch back ported to > 2.8?
No particular reason I just thought to point that out since in other parts of this file dpdk_port_t is used for the port_id, for example in the netdev_dpdk_process_devargs() and netdev_dpdk_set_config() functions so maybe worth fixing these inconsistencies. -- markos SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
