On Wed, Jan 10, 2018 at 1:27 PM, Ben Pfaff <[email protected]> wrote: > On Wed, Jan 10, 2018 at 10:04:48AM -0800, William Tu wrote: >> Existing code only set these tunnel flags (df, csum, and key) when the >> flag is set in the output tunnel port, but did not clear when the flag >> is unset. The patch fixes it by setting and clearing it accordingly. >> >> Two existing testcases need to fix: >> 'tunnel - Geneve option present' has no key set up, so we should match >> 'flags(df)' instead of 'flags(df|key)'. The second case >> 'tunnel - concomitant IPv6 and IPv4 tunnels' follows the same pattern. >> One additional test case 'tunnel - Mix Geneve/GRE options' is added. >> >> VMWare-BZ: #2019012 >> Signed-off-by: William Tu <[email protected]> > > Good catch. Thank you! > > Another way to solve this would be to add: > flow->tunnel.flags &= ~(FLOW_TNL_F_MASK & ~FLOW_TNL_PUB_F_MASK); > above the existing code. Your way is fine too. Which do you prefer?
I like this one line solution. I will send v2 patch. Thanks William _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
